refactor(vault-cli): use default = null instead of default = "" for vault_token

[luyi66243-maker]

Summary

Replace default = "" with default = null for the vault_token variable in the vault-cli module, addressing part of #755.

Using null instead of "" is better Terraform practice — it semantically means "not provided" rather than "provided but empty". This also aligns vault_token with the existing vault_namespace variable in the same module, which already uses default = null.

Changes

• vault_token default: "" → null
• templatefile call: added null guard (var.vault_token != null ? var.vault_token : "") to safely pass to shell template
• coder_env.vault_token count: changed condition from != "" to != null

Testing

All 10 existing Terraform tests pass without modification:

$ terraform test -verbose
  run "test_vault_cli_without_token"... pass
  run "test_vault_cli_with_token"... pass
  run "test_vault_cli_custom_version"... pass
  run "test_vault_cli_custom_install_dir"... pass
  run "test_vault_cli_invalid_version"... pass
  run "test_vault_cli_valid_semver"... pass
  run "test_vault_cli_rejects_v_prefix"... pass
  run "test_vault_cli_with_namespace"... pass
  run "test_vault_cli_with_token_and_namespace"... pass
  run "test_vault_cli_enterprise"... pass

Success! 10 passed, 0 failed.

Notes

This is a scoped first step toward #755. If the approach is acceptable, I'm happy to submit follow-up PRs for other modules.

[DevelopmentCats]

@luyi66243-maker

Looks Like a quick and easy fix. All we need is the version to be bumped in the module for this if you could run the version bump scripts we should be good here.

Thank you for your first Contribution on our repo!

[luyi66243-maker]

Thanks for the quick review! I ran the version bump script for this module and pushed the update.\n\n- Module bumped: \n- Version: → \n\nCould you please take another look?

[luyi66243-maker]

Correction (formatting issue in my previous comment):

Thanks for the quick review! I ran the version bump script for this module and pushed the update.

• Module bumped: coder/vault-cli
• Version: v1.1.1 -> v1.1.2

Could you please take another look?

[DevelopmentCats]

Correction (formatting issue in my previous comment):

Thanks for the quick review! I ran the version bump script for this module and pushed the update.

• Module bumped: coder/vault-cli
• Version: v1.1.1 -> v1.1.2

Could you please take another look?

Can you run bun run fmt on this so the Linter is satisfied?