fix(zed): fix settings JSON parsing with base64 encoding #604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Zed module's settings parsing was broken. The previous implementation used quote escaping:
This produced invalid JSON like
{\"theme\":\"dark\"}which jq could not parse because the backslash-escaped quotes are not valid JSON syntax.Solution
Changed to use base64 encoding internally:
User interface remains the same - users still provide plain JSON via
jsonencode()or heredoc:Testing
Added comprehensive tests:
Terraform tests (5):
Container e2e tests (3):
Also fixed existing tests to use
override_datafor proper workspace mocking.