fix(git-clone): use unique temp file for post_clone_script to avoid race condition #601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition when multiple
git-clonemodules withpost_clone_scriptrun concurrently.Problem
All instances of the git-clone module use the same hardcoded
/tmp/post_clone.shpath. When multiple modules run concurrently (or overlap), they collide on the same temp file, causing:This results in a non-zero exit code, causing the workspace to appear unhealthy.
Solution
Use
mktempto generate a unique temporary filename for each module instance:POST_CLONE_TMP=$(mktemp /tmp/post_clone_XXXXXX.sh)This ensures each concurrent execution uses its own temp file, eliminating the race condition.
Fixes #600