fix: detect missing repo in ensureReady #2015
Conversation
ethanndickson
force-pushed
the
fix/repo-preflight-ensure-ready
branch
from
57e6c63 to
2f122ac
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57e6c63f6f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 09bfe4b6da
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ethanndickson
force-pushed
the
fix/repo-preflight-ensure-ready
branch
from
a63da29 to
0c3cf20
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
SSH/Coder ensureReady() now accepts .git as file or directory, fixing false runtime_not_ready classification for valid git worktrees. - Update checkWorkspaceRepo() preflight: test -d || test -f - Add tests for worktree file, missing repo, and missing git scenarios
ethanndickson
force-pushed
the
fix/repo-preflight-ensure-ready
branch
from
466473e to
c6257c2
Compare
ethanndickson
changed the title
ethanndickson
changed the title
1 participant
Summary
.gitfiles (worktree support).Background
test -d .gitwhich fails for git worktrees (where.gitis a file).Implementation
test -d || test -fthengit rev-parse) to distinguish missing repo vs connection/command failures and support worktrees..gitpresence, allowing non-git directories to be ready.Validation
make static-checkbun test src/node/runtime/SSHRuntime.test.tsbun test src/node/runtime/LocalRuntime.test.tsRisks
Generated with
mux• Model:openai:gpt-5.2-codex• Thinking:high• Cost:$21.57