Skip to content

Conversation

@ammar-agent
Copy link
Collaborator

Summary:

  • Unify Review panel refresh behavior so tool-driven updates refresh the untracked banner while focused.
  • Pause scheduled refreshes only while composing review notes to protect drafts.
  • Update the ReviewPanel refresh integration test expectations.

Background:

  • Scheduled refreshes were paused whenever the Review panel had focus, which kept untracked files stale until a manual refresh or blur.

Implementation:

  • Scope RefreshController pause to isComposingReviewNoteRef only.
  • Keep manual refresh blocking during composition.
  • Update focus-refresh integration test to reflect the new behavior.

Validation:

  • make static-check
  • make test

Risks:

  • Low–Medium: refreshes can now occur while the panel is focused, which could shift selection/scroll on tool completion; draft notes remain protected by the composition pause.

Generated with mux • Model: openai:gpt-5.2-codex • Thinking: xhigh • Cost: $5.85

@github-actions github-actions bot added the bug label Jan 29, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 78dd948631

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@ammar-agent
Copy link
Collaborator Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bc3dfad2c0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@ammar-agent ammar-agent force-pushed the fix/review-untracked-refresh branch from bc3dfad to b458608 Compare January 29, 2026 16:34
@ammar-agent
Copy link
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@ammario ammario merged commit fe9a161 into main Jan 29, 2026
23 checks passed
@ammario ammario deleted the fix/review-untracked-refresh branch January 29, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants