Skip to content

fix: Respond to the device attributes sequences #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sazary wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Respond to the device attributes sequences #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions patches/ghostty-wasm-api.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ new file mode 100644
index 000000000..d57b4e405
--- /dev/null
+++ b/src/terminal/c/terminal.zig
@@ -0,0 +1,1004 @@
@@ -0,0 +1,1025 @@
+//! C API wrapper for Terminal
+//!
+//! This provides a minimal, high-performance interface to Ghostty's Terminal
Expand All @@ -419,6 +419,7 @@ index 000000000..d57b4e405
+const Terminal = @import("../Terminal.zig");
+const stream = @import("../stream.zig");
+const Action = stream.Action;
+const ansi = @import("../ansi.zig");
+const render = @import("../render.zig");
+const RenderState = render.RenderState;
+const color = @import("../color.zig");
Expand Down Expand Up @@ -456,6 +457,7 @@ index 000000000..d57b4e405
+ switch (action) {
+ // Device status reports - these need responses
+ .device_status => try self.handleDeviceStatus(value.request),
+ .device_attributes => try self.handleDeviceAttributes(value),
+
+ // All the terminal state modifications (same as stream_readonly.zig)
+ .print => try self.terminal.print(value.cp),
Expand Down Expand Up @@ -589,7 +591,6 @@ index 000000000..d57b4e405
+ .request_mode_unknown,
+ .size_report,
+ .xtversion,
+ .device_attributes,
+ .kitty_keyboard_query,
+ .window_title,
+ .report_pwd,
Expand Down Expand Up @@ -632,6 +633,26 @@ index 000000000..d57b4e405
+ }
+ }
+
+ fn handleDeviceAttributes(self: *ResponseHandler, req: ansi.DeviceAttributeReq) !void {
+ // Match main Ghostty behavior for device attribute responses
+ switch (req) {
+ .primary => {
+ // DA1 - Primary Device Attributes
+ // Report as VT220 with color support (simplified for WASM)
+ // 62 = Level 2 conformance, 22 = Color text
+ try self.response_buffer.appendSlice(self.alloc, "\x1B[?62;22c");
+ },
+ .secondary => {
+ // DA2 - Secondary Device Attributes
+ // Report firmware version 1.10.0 (matching main Ghostty)
+ try self.response_buffer.appendSlice(self.alloc, "\x1B[>1;10;0c");
+ },
+ else => {
+ // DA3 and other requests - not implemented in WASM context
+ },
+ }
+ }
+
+ inline fn horizontalTab(self: *ResponseHandler, count: u16) !void {
+ for (0..count) |_| {
+ const x = self.terminal.screens.active.cursor.x;
Expand Down