ci: make generated cask pass brew style#253
Merged
Merged
Conversation
The cask generated by `scripts/update-cask.sh` failed `brew test-bot --only-tap-syntax` on the homebrew-coder side with two autocorrectable offenses: - `Homebrew/OSDependsOn`: use the symbol form `depends_on macos: :sonoma` instead of `">= :sonoma"` (still means "Sonoma or newer"). - `Cask/ArrayAlphabetization`: the `zap delete:` array must be sorted, so `coder-darwin-amd64` goes before `coder-darwin-arm64`. This regenerates a cask that passes `brew style` on the next release.
ethanndickson
changed the title
brew stylebrew style
jakehwll
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cask emitted by
scripts/update-cask.sh(invoked from theupdate-caskjob in.github/workflows/release.yml) currently failsbrew test-bot --only-tap-syntaxon the homebrew-coder side. See this run, which blocked coder/homebrew-coder#360 for thev0.8.1release.Two autocorrectable
brew styleoffenses, both originating from the heredoc inscripts/update-cask.sh:Homebrew/OSDependsOn: prefer the symbol formdepends_on macos: :sonomaover">= :sonoma"(semantically equivalent — still means "Sonoma or newer").Cask/ArrayAlphabetization: thezap delete:array must be ordered alphabetically, socoder-darwin-amd64belongs beforecoder-darwin-arm64.The corresponding open PR on coder/homebrew-coder has already been amended directly with the same two-line fix to unblock the v0.8.1 release. This PR ensures future releases generate a cask that passes
brew stylewithout manual cleanup.