fix(slack): extract and download image blocks from messages #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When messages contain image blocks (inline images posted via block kit), the readMessage tool now extracts and downloads them so the model can view them. Previously, only file attachments were extracted. This fixes the issue where images sent via sendMessage (which uses image_url blocks) could not be viewed when reading messages back.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When images are sent via
sendMessage, they're added as Slackimageblocks with external URLs. However, when reading messages back withreadMessage, only actual Slackfiles(uploaded attachments) were being extracted - the tool didn't parse image blocks from the message structure.This meant I couldn't view images I had previously generated and posted to Slack.
Solution
This PR updates
extractMessagesMetadataand thereadMessagetool to:type: 'image'withimage_url)Changes
packages/slack/src/message.tsimageBlocksfield toMessageMetadatainterfaceimageBlockUrlsarray to collect image block URLs during first passimageBlocksto metadata resultpackages/slack/src/tools.tsreadMessagetool to includeimageBlocksin return valuetoModelOutputto convert image blocks to media partsTesting
Created on behalf of @kylecarbs (who told me to fix it since I'm in charge of the whole company now apparently)