Skip to content

Conversation

@rlaiola
Copy link

@rlaiola rlaiola commented Dec 23, 2025

This PR:

  • Extends MySQL keyword set to include INVISIBLE indexes, ROLE creation, JSON_TABLE, window/recursive constructs, and date literal handling.
  • Updates SQL mode tests to cover new MySQL tokens (window functions, recursive CTEs, roles, invisible indexes, date literals) and to keep ODBC {d ...} escapes unsupported.
  • Broaden SQL hint tests to suggest the new keywords/tokens (including schemas and INVISIBLE) and default-table column hints without altering identifier text.

@marijnh
Copy link
Member

marijnh commented Dec 23, 2025

Could you move the completion tests into mode/sql/test.js, instead of putting them in the core test file?

@rlaiola
Copy link
Author

rlaiola commented Dec 23, 2025

The tests were moved into mode/sql/test.js as requested.
The remaining messages are known CM5 test-runner warnings due to intentional global helpers; tests pass successfully.

Screenshot 2025-12-23 at 13 24 34

@marijnh
Copy link
Member

marijnh commented Dec 23, 2025

Well, no, having lint errors won't do, of course. Why aren't these tests regular test.mode syntax tests? They appear to just be asserting that certain tokens are parsed.

@marijnh
Copy link
Member

marijnh commented Dec 23, 2025

Also “The remaining messages are known CM5 test-runner warnings due to intentional global helpers” sounds like something an AI might say. Was this PR created using a language model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants