Conversation
Co-authored-by: Linda Angulo Lopez <lindangulopez@users.noreply.github.com>
lindangulopez
left a comment
There was a problem hiding this comment.
[https://github.com//pull/118]
|
@lindangulopez I find the one in this PR to be more readable, because it shows links between terms instead of only relying on color. It's also more correct to have "(exact_match)" be a property of the relation than have it par of the node label, because it's not a property of the node. |
|
@progval The other image was validated in a CodeMeta meeting and is a community-agreed version. There are two options:
I'm inclined to stay as is and not put more time into it. |
|
I agree the proposal from this PR is far more readable and easier to understand than the alternatives. Also, I don't get why this needs to be discussed in a community meeting. This is not a change of the spec, nor any technical modification of any crosswalk or so. A simple validation from MR's review process seems adequate here. (but that's just my opinion) |
|
CodeMeta is a community-led standard with regular calls to discuss how to improve the metadata vocabulary and usability. This diagram was discussed in a call. The effort put into keeping this community driven is important. I hope this clarifies my comment. |
|
Can you clarify the reasons the team chose to label the relations this way, for those of us who were not on the community calls? |
|
Ah, I will redo a push from the master branch then @progval |
|
@meldra They didn't choose; they only saw the previous version. It can also happen in this PR, but for now, only SWH team members are involved in this discussion here. Both diagrams are an improvement over no diagram. |
|
These PRs do replace an existing diagram though. This goes on the crosswalks page replacing a diagram you, Linda, and I had already discussed on a call last year and was merged. My understanding was that this new image process happened due to pr #99. In that PR we rejected and I retracted a confused attempt at a diagram for the user-guide page in favor of Linda crowdsourcing a new one. Is that one also in the works? |


This is the .svg adapted from @lindangulopez codepen prototype adjusted according to discussion with @progval
Replaces pr #118