Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rajat1saxena
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c20c0b269
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (typeof drip.status === "boolean") { | ||
| $set["groups.$.drip.status"] = drip.status; |
There was a problem hiding this comment.
drip.type when accepting status: false
Because DripInput.type is optional in apps/web/graphql/courses/types/index.ts:86-95 but Drip.type is non-null on reads at apps/web/graphql/courses/types/index.ts:97-103, this new branch can create a partial groups.$.drip object when a client sends updateGroup(..., drip: { status: false }) for a group that has never had drip configured. In that case the mutation stores drip.status without any drip.type, and subsequent reads of that group can fail with Cannot return null for non-nullable field Drip.type.
Useful? React with 👍 / 👎.
| if (typeof drip.status === "boolean") { | ||
| $set["groups.$.drip.status"] = drip.status; |
There was a problem hiding this comment.
/workspace/courselit/AGENTS.md says to "Always add or update test when introducing changes to apps/web/graphql folder," but this patch changes updateGroup in apps/web/graphql/courses/logic.ts without adding coverage for the new status === false path. That leaves the exact "drip settings cannot be switched off" regression unguarded, so this behavior can silently break again.
Useful? React with 👍 / 👎.
1 participant
No description provided.