Skip to content

test: refactor NothingPersonalValidatorTest #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 2 commits into from
Jul 11, 2025
Merged

test: refactor NothingPersonalValidatorTest #1274

samsonasik merged 2 commits into from
Jul 11, 2025

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Jul 11, 2025

Description

  • First commit is cosmetic change and fixing wrong types
  • Second commit is the actual fix. It's just plain wrong to compare two Closures together. I believe this meant to test the outputs of those closures.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label Jul 11, 2025
@samsonasik samsonasik merged commit 17879df into codeigniter4:develop Jul 11, 2025
33 of 37 checks passed
@samsonasik
Copy link
Member

samsonasik commented Jul 11, 2025

Thank you @paulbalandan

@paulbalandan paulbalandan deleted the test-nothing-personal branch July 11, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

Assignees

No one assigned

Labels

testing Pull requests that changes tests only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan @samsonasik @michalsn