refactor: do not use future-deprecated DATE_RFC7231 constant#9657
Merged
paulbalandan merged 1 commit intocodeigniter4:4.7from Aug 3, 2025
Merged
refactor: do not use future-deprecated DATE_RFC7231 constant#9657paulbalandan merged 1 commit intocodeigniter4:4.7from
DATE_RFC7231 constant#9657paulbalandan merged 1 commit intocodeigniter4:4.7from
Conversation
Member
|
While the constant is deprecated, I don't believe we should ditch the GMT format here, as the |
Member
Author
|
Yes, that is true. But we are just relying this time on the |
michalsn
approved these changes
Aug 3, 2025
Member
michalsn
left a comment
There was a problem hiding this comment.
With gmdate() that makes sense. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It will be deprecated in PHP 8.5: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_date_rfc7231_and_datetimeinterfacerfc7231
Checklist: