fix: SMTP connection resource validation in Email class destructor#9648
Merged
samsonasik merged 6 commits intocodeigniter4:developfrom Jul 30, 2025
Merged
fix: SMTP connection resource validation in Email class destructor#9648samsonasik merged 6 commits intocodeigniter4:developfrom
Email class destructor#9648samsonasik merged 6 commits intocodeigniter4:developfrom
Conversation
Member
Author
|
No tests are provided, as I'm not sure how this could be tested effectively. However, since this is a regression from v4.6.1, I believe it's acceptable without tests in this case. |
paulbalandan
approved these changes
Jul 30, 2025
samsonasik
approved these changes
Jul 30, 2025
Member
|
Thank you @michalsn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the destructor was checking
$this->SMTPConnect !== nullto validate SMTP connections.However,
fclose()creates closed resources that are notnull, which led to unnecessary cleanup attempts on already-closed connections.When the
SMTPKeepAliveoption isfalse(the default), thequitcommand is called before the destructor is reached.Fixes #9647
Checklist: