fix: improve CURLRequest intermediate HTTP response handling#9627
Merged
michalsn merged 1 commit intocodeigniter4:developfrom Jul 10, 2025
Merged
fix: improve CURLRequest intermediate HTTP response handling#9627michalsn merged 1 commit intocodeigniter4:developfrom
michalsn merged 1 commit intocodeigniter4:developfrom
Conversation
paulbalandan
approved these changes
Jul 9, 2025
Member
Author
|
Thank you @paulbalandan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in
CURLRequestwhere intermediate HTTP responses were not properly removed from the response chain in certain scenarios, causing incorrect status codes and headers to be returned instead of the final response.The problem was that the original logic processed different types of intermediate responses separately, which could miss responses that appeared in mixed order.
send()method to use unified intermediate response removalhandleRedirectHeaders()private methodremoveIntermediateResponses()andshouldRemoveCurrentResponse()private methods, which now handle the entire process of intermediate headers removalThe issue was reported on the forum: https://forum.codeigniter.com/showthread.php?tid=93094&pid=426075#pid426075
Checklist: