fix: support for multibyte folder names when the app is served from a subfolder#9615
Merged
michalsn merged 1 commit intocodeigniter4:developfrom Jun 30, 2025
Conversation
michalsn
added
the
bug
5 tasks
samsonasik
approved these changes
Jun 28, 2025
paulbalandan
approved these changes
Jun 28, 2025
michalsn
force-pushed
the
fix/multibyte-characters-in-folder-name
branch
from
9e157f0 to
3b5b6ff
Compare
michalsn
force-pushed
the
fix/multibyte-characters-in-folder-name
branch
from
3b5b6ff to
06f1944
Compare
Member
Author
|
Thank you @samsonasik and @paulbalandan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where folder names containing multibyte (non-ASCII) characters were not correctly resolved by
SiteURIFactory::parseRequestURI()when the application was served from a subfolder.The problem was spotted here: #9613 (comment)
Needs #9613
Checklist: