Skip to content

refactor: Fix phpstan varTag.type errors#9480

Merged
paulbalandan merged 5 commits intocodeigniter4:developfrom
neznaika0:refactor/phpstan-varTag.type
Mar 11, 2025
Merged

refactor: Fix phpstan varTag.type errors#9480
paulbalandan merged 5 commits intocodeigniter4:developfrom
neznaika0:refactor/phpstan-varTag.type

Conversation

@neznaika0
Copy link
Contributor

Description

  • Redis::scan() does not return Redis.
  • config() already supports the hint for classes. Removed the creation of a one-time variable.
  • TimeTrait::$timezone it can be a string during initialization.
  • It seems that Closure(mixed...) cannot be specified, so I only changed the return type.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan merged commit 770e067 into codeigniter4:develop Mar 11, 2025
48 of 49 checks passed
@neznaika0 neznaika0 deleted the refactor/phpstan-varTag.type branch March 11, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants