fix: set headers for CORS#9437
Merged
michalsn merged 4 commits intocodeigniter4:developfrom Feb 8, 2025
Merged
Conversation
samsonasik
approved these changes
Jan 28, 2025
Member
|
If a dev creates an new Response in a controller, the CORS header will not be added. |
Member
Author
Fair point. |
Member
Author
|
Second approach. I don't know if we should go into more detail about checking the required headers, but this seems enough. Basically, we now add CORS headers in the |
samsonasik
approved these changes
Jan 31, 2025
Closed
paulbalandan
approved these changes
Feb 7, 2025
Member
Author
|
Thank you @samsonasik and @paulbalandan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where CORS was not set correctly due to the response object being returned in the
beforefilter.Now all CORS headers are set in thebeforefilter, and theafterfilter is no longer used.This change should not break anyone's code.
Fixes #9431
Checklist: