Merged
Conversation
JeromeBu
reviewed
Mar 19, 2026
JeromeBu
reviewed
Mar 19, 2026
|
|
||
| return Object.fromEntries( | ||
| Object.entries(groupedData).map(([wikidataId, { license }]) => [wikidataId, license.split("/").reverse()[0]]) | ||
| ); |
Collaborator
There was a problem hiding this comment.
j'ai pas vu de tests nouveau pour valider les nouveaux comportement wikidata. Les existants étaient suffisant ?
Collaborator
Author
There was a problem hiding this comment.
C'est juste un déplacement des appels API qui était au niveau au dessus.
L'idée était de les déplacer ici pour commencer si possible à les factoriser et gagner en lisibilité.
guillermau
force-pushed
the
config-on-source
branch
from
91e8554 to
736bed8
Compare
guillermau
force-pushed
the
config-on-source
branch
from
f060110 to
2e7f1fe
Compare
JeromeBu
approved these changes
Apr 16, 2026
JeromeBu
force-pushed
the
config-on-source
branch
from
2e7f1fe to
313f1e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.