CG-1234: Add comments and reviews to GithubViewPRTool#935
Draft
codegen-sh[bot] wants to merge 2 commits intodevelopfrom
Draft
CG-1234: Add comments and reviews to GithubViewPRTool#935codegen-sh[bot] wants to merge 2 commits intodevelopfrom
codegen-sh[bot] wants to merge 2 commits intodevelopfrom
Conversation
tawsifkamal
reviewed
Mar 24, 2025
| modified_symbols: list[str] = Field( | ||
| description="Names of modified symbols in the PR", | ||
| ) | ||
| comments: list[dict[str, Any]] = Field( |
Contributor
There was a problem hiding this comment.
Can you please call this github_comments?
Contributor
Author
|
I've addressed the review comment by renaming the |
tawsifkamal
approved these changes
Mar 24, 2025
| description="Comments on the PR", | ||
| default_factory=list, | ||
| ) | ||
| reviews: list[dict[str, Any]] = Field( |
Contributor
There was a problem hiding this comment.
maybe call this github_reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for including comments and reviews in the
GithubViewPRTooloutput.Changes:
ViewPRObservationclass to include fields for comments and reviewsget_modified_symbols_in_prmethod in theCodebaseclass to fetch and return PR comments and reviewsmoddified_symbols->modified_symbols)Implementation Details:
Fixes the issue mentioned in Slack: https://codegencommunity.slack.com/archives/C08JKKP35PT/p1742572530749669?thread_ts=1742408765.927599&cid=C08JKKP35PT