Update search tool to include filename matches#873
Draft
codegen-sh[bot] wants to merge 2 commits intodevelopfrom
Draft
Update search tool to include filename matches#873codegen-sh[bot] wants to merge 2 commits intodevelopfrom
codegen-sh[bot] wants to merge 2 commits intodevelopfrom
Conversation
|
codegen-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the search tool to include filenames in search results, addressing the issue where searching for a specific filename would return no results even if the file exists.
Changes:
filename_matchfield to theSearchFileResultclass to indicate when a filename matches the search queryfindcommand to search for matching filenamesTesting:
The updated search tool will now return files whose names match the search query, even if the file content doesn't contain the query. This makes it easier to find specific files in the codebase.
For example, searching for "search.py" will now return the file even if the content doesn't contain that exact string.
Fixes the issue where the search tool was not taking into account filenames.