CG-12125: Fix TSCodeBlock missing end_byte_for_condition_block attribute#844
Closed
codegen-sh[bot] wants to merge 2 commits intodevelopfrom
Closed
CG-12125: Fix TSCodeBlock missing end_byte_for_condition_block attribute#844codegen-sh[bot] wants to merge 2 commits intodevelopfrom
codegen-sh[bot] wants to merge 2 commits intodevelopfrom
Conversation
|
codegen-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the cloud parse failure due to
TSCodeBlockmissing theend_byte_for_condition_blockattribute.Problem
The error occurs during dependency resolution in the
resolve_namemethod incodegen/sdk/core/expressions/name.py. When resolving names in conditional blocks, it tries to accessend_byte_for_condition_blockon aTSCodeBlockobject, but this attribute is not implemented forTSCodeBlock.The error message is:
Solution
Added the
end_byte_for_condition_blockproperty toTSCodeBlockclass, which simply returns theend_bytevalue, matching the default implementation in theConditionalBlockinterface.Related Linear Issue
https://linear.app/codegen-sh/issue/CG-12125/fix-tscodeblock-missing-end-byte-for-condition-block-attribute