Improve RelaceEditTool error handling for file not found errors#826
Merged
Improve RelaceEditTool error handling for file not found errors#826
Conversation
|
codegen-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
jayhack
approved these changes
Mar 12, 2025
tkfoss
pushed a commit
that referenced
this pull request
Mar 14, 2025
## Description
This PR improves the error handling in the `RelaceEditTool` when a file
is not found. Instead of raising a `FileNotFoundError` exception, it now
returns a `RelaceEditObservation` with an error status and a helpful
message.
## Changes
- Modified the `relace_edit` function to return a
`RelaceEditObservation` with an error status when a file is not found
- Added a more descriptive error message that includes the full filepath
and suggests using the full filepath relative to the repository root
## Why
Previously, when a user provided an invalid filepath to the
`RelaceEditTool`, it would raise a `FileNotFoundError` exception that
wasn't properly passed back to the assistant as an observation. This
change ensures that file not found errors are handled consistently with
other errors and returned as observations, allowing the assistant to
handle them gracefully.
Fixes the issue where users would see errors like:
```
FileNotFoundError('File not found: codegen_agi.py')
```
instead of getting a helpful error message as part of the tool's
observation.
---------
Co-authored-by: codegen-bot <team+codegenbot@codegen.sh>
Co-authored-by: codegen-sh[bot] <131295404+codegen-sh[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the error handling in the
RelaceEditToolwhen a file is not found. Instead of raising aFileNotFoundErrorexception, it now returns aRelaceEditObservationwith an error status and a helpful message.Changes
relace_editfunction to return aRelaceEditObservationwith an error status when a file is not foundWhy
Previously, when a user provided an invalid filepath to the
RelaceEditTool, it would raise aFileNotFoundErrorexception that wasn't properly passed back to the assistant as an observation. This change ensures that file not found errors are handled consistently with other errors and returned as observations, allowing the assistant to handle them gracefully.Fixes the issue where users would see errors like:
instead of getting a helpful error message as part of the tool's observation.