fix: use B for back instead of Esc character#1211
Merged
rushilpatel0 merged 1 commit intodevelopfrom Aug 19, 2025
Merged
Conversation
codegen-team
approved these changes
Aug 19, 2025
Codecov Report❌ Patch coverage is
|
Contributor
|
🎉 This PR is included in version 0.56.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
![codegen-sh[bot]](https://avatars.githubusercontent.com/in/321279?s=60&v=4){kind=small}
| import select | ||
| from datetime import datetime | ||
| from typing import Any | ||
|
|
Contributor
There was a problem hiding this comment.
Input handling regression: Removing select breaks bare ESC handling
Without select, a lone ESC blocks on read(1). Keep select to non-blockingly detect escape sequences.
Suggested change
| import select |
| import select | ||
| from datetime import datetime | ||
| from typing import Any | ||
|
|
Contributor
There was a problem hiding this comment.
Logic bug: Back action only recognizes uppercase 'B'
Lowercase 'b' (common in fallback input mode and when users type without Shift) won’t trigger back. Accept both cases.
Suggested change
| # In _show_post_creation_menu loop | |
| elif key.lower() == "b": # Back to new tab | |
| self.current_tab = 1 # 'new' tab index | |
| self.input_mode = True | |
| break | |
| # In _handle_input_mode_keypress | |
| if key.lower() == "b": # Back action in new tab | |
| self.input_mode = False |
Contributor
|
Found 2 issues. Please review my inline comments above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Content
Testing
Please check the following before marking your PR as ready for review