Merged
Conversation
codegen-team
requested review from
christinewangcw
and removed request for
a team
Codecov Report❌ Patch coverage is
|
![codegen-sh[bot]](https://avatars.githubusercontent.com/in/321279?s=60&v=4){kind=small}
| if key == "\x03": # Ctrl+C | ||
| self.running = False | ||
| return | ||
| elif key.lower() == "q" and not (self.input_mode and self.current_tab == 1): # q only if not typing in new tab |
Contributor
There was a problem hiding this comment.
Logic bug: ESC cancel never triggers, UI freezes
_handle_input_mode_keypress now checks for a raw "\x1b", but _get_char() always tries to read a second byte after an ESC press (to capture arrow keys). When the user presses ESC by itself the call blocks and the handler never receives the single byte, effectively freezing the TUI. Accept both "c" and any sequence that STARTS with ESC.
Suggested change
| elif key.lower() == "q" and not (self.input_mode and self.current_tab == 1): # q only if not typing in new tab | |
| # Accept either raw "c" (legacy) or a lone ESC / ESC-sequence that is *not* an arrow key | |
| if key.lower() == "c" or key == "\x1b" or key.startswith("\x1b[") is False: | |
| self.input_mode = False |
Contributor
|
Found 1 issues. Please review my inline comments above. |
Contributor
|
🎉 This PR is included in version 0.56.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Content
Testing
Please check the following before marking your PR as ready for review