CG-17310: Disable PR creation Sentry errors#1041
Open
codegen-sh[bot] wants to merge 2 commits intodevelopfrom
Open
CG-17310: Disable PR creation Sentry errors#1041codegen-sh[bot] wants to merge 2 commits intodevelopfrom
codegen-sh[bot] wants to merge 2 commits intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When trying to create a PR on a branch that already has a PR, a Sentry error is generated and the agent is not shown a good error message.
Changes
GitRepoClient.create_pullto check if a PR already exists for the branch before attempting to create a new oneCodebase.create_prto useget_or_create_pullinstead ofcreate_pullto handle the case when a PR already existsTesting
Added a new test case
test_codebase_create_pr_existing_prthat verifies the behavior when trying to create a PR on a branch that already has a PR.Fixes CG-17310
💻 View my work • About Codegen