Add presenter analysis script to identify simple repeats in vm methods#1008
Open
codegen-sh[bot] wants to merge 2 commits intodevelopfrom
Open
Add presenter analysis script to identify simple repeats in vm methods#1008codegen-sh[bot] wants to merge 2 commits intodevelopfrom
codegen-sh[bot] wants to merge 2 commits intodevelopfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I've reviewed the PR and it looks good! The A few observations:
While I don't see any presenter files in the current codebase that match the pattern this script is looking for, I understand this might be a utility for future code or for analyzing code in other repositories. The Codecov report shows all modified and coverable lines are covered by tests, which is excellent. This looks ready to merge! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Python script that analyzes presenter files to identify properties in the
vmmethod that are simple repeats.What it does
The script:
vmmethod in each fileExample
For presenter files with code like:
The script will identify
nameandtitleas simple repeats.Usage
If no directory path is provided, the script will search in the current directory.
Files Added
scripts/analyze_presenters.py: The main scriptscripts/README.md: Documentation for the script