Add standalone script to remove empty object parameters from usePresenter calls#1007
Open
codegen-sh[bot] wants to merge 2 commits intodevelopfrom
Open
Add standalone script to remove empty object parameters from usePresenter calls#1007codegen-sh[bot] wants to merge 2 commits intodevelopfrom
codegen-sh[bot] wants to merge 2 commits intodevelopfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I've reviewed this PR which adds a standalone script to remove empty object parameters from Code Quality ✅
Implementation Details 👍
Documentation 📝
This standalone script complements the SDK-based version in PR #1005 nicely, providing a lightweight alternative that can be used in any codebase without additional dependencies. The Codecov report shows good test coverage, and I don't see any issues that would prevent this from being merged. Great work! 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a standalone Python script that finds all usages of
usePresenterin the codebase and removes the second parameter when it's an empty object ({}). Unlike the existing script in PR #1005, this script doesn't rely on the Codegen SDK and can be used in any codebase without additional dependencies.Features
usePresenterwhere the second parameter is an empty objectUsage
Examples
Before:
After:
Before:
After: