Skip to content

Fix Loading State in Newsfeed#2103

Open
ACoullard wants to merge 1 commit intocodeforboston:mainfrom
ACoullard:AC/fix-loading-state-in-newsfeed
Open

Fix Loading State in Newsfeed#2103
ACoullard wants to merge 1 commit intocodeforboston:mainfrom
ACoullard:AC/fix-loading-state-in-newsfeed

Conversation

@ACoullard
Copy link
Copy Markdown
Collaborator

Summary

Expands the loading state logic for the NewsFeed page such that it now waits for both the user's profile to be resolved and the latest notifications to be fetched and filtered, before attempting to display the main content.

Addresses issue #2099

This means:

  • adding a new loading state to track the status of fetching the latest notifications
  • moving filtering out of a useEffect into a useMemo

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.
  • If I've added new Firestore queries, I've added any new required indexes to firestore.indexes.json (Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)

Steps to test/reproduce

Log in as a user who has notifications on their NewsFeed. (or manufacture notification on their news feed)
Refresh the page and observe / add logging statements and verify that the "noResults" version of the component never appears when it shouldn't.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
maple-dev Ready Ready Preview, Comment Apr 15, 2026 1:35am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Frontend development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant