Updated requirements of psycopg2 and pillow to new version.#127
Updated requirements of psycopg2 and pillow to new version.#127endy-imam wants to merge 4 commits intocodeforboston:masterfrom
Conversation
zganger
left a comment
zganger
left a comment
There was a problem hiding this comment.
Glad this is now working on the tests- I have submitted several review suggestions to reduce the changeset.
.github/workflows/lint-and-test.yml
Outdated
| black . | ||
| - name: Test with django | ||
| run: | | ||
| python manage.py test |
There was a problem hiding this comment.
This file already exists- seems like it was pulled in on merge? can you rebase onto upstream/master and push back to your fork?
There was a problem hiding this comment.
I was hoping to find some way to undo that - I will get around rebasing it.
requirements.txt
Outdated
| pytz==2018.9 | ||
| requests==2.21.0 | ||
| simplejson==3.16.0 | ||
| soupsieve==2.0 |
There was a problem hiding this comment.
soupsieve and python-dotenv are just recursive dependencies? Is there a reason you're locking them? If the top-level package requirement guarantees compatibility, we shouldn't need to include all the sub-dependencies with locks in the main file. It will make it more difficult to manage dependencies effectively in the future if we try to track the dependencies of the dependencies as well.
There was a problem hiding this comment.
soupsieve is a transitive dependency, but python-dotenv is not. I added python-dotenv to the requirements in #121 to make it easier for people to set up their development environments.
There was a problem hiding this comment.
seems that belongs in dev_requirements.txt then- not to be built into deployment packages?
There was a problem hiding this comment.
I am gonna move the python-dotenv to the dev_requirements.txt. Question being: should that version be locked? I am gonna leave the version unlocked for the time being, but let me know if there is anything else regarding it.
This is to allow compatibility for Python 3.8 for newcomers while retaining support for 3.6 and 3.7
endy-imam
force-pushed
the
update-requirements
branch
from
40a7595 to
8462826
Compare
|
Got done with the rebase and now I am gonna take out the transitive dependency of beautifulsoup4 |
3 participants
This is to allow compatibility for Python 3.8 for newcomers while retaining support for 3.6 and 3.7.