⚡️ Speed up method CacheFactory.get_cache_types by 27%

[codeflash-ai]

📄 27% (0.27x) speedup for CacheFactory.get_cache_types in graphrag/cache/factory.py

⏱️ Runtime : 4.49 microseconds → 3.54 microseconds (best of 78 runs)

📝 Explanation and details

The optimization replaces list(cls._registry.keys()) with [*cls._registry] (unpacking syntax). This change eliminates the intermediate dict_keys object creation step that occurs with .keys(). When using unpacking syntax [*dict], Python directly iterates over the dictionary's keys without creating the intermediate view object, resulting in fewer function calls and object allocations.

The 26% speedup comes from avoiding the overhead of:

1. Calling the .keys() method
2. Creating a dict_keys view object
3. Passing that view to the list() constructor

The unpacking approach directly constructs the list from the dictionary's key iteration, which is more efficient in CPython's implementation. Both approaches preserve the same iteration order (insertion order in modern Python dictionaries) and produce identical results.

The test results show consistent performance gains across different scenarios (17.9-26.7% faster), indicating this optimization is particularly effective for small to medium-sized registries, which is typical for factory pattern implementations like cache type registration.

✅ Correctness verification report:

Test	Status
⚙️ Existing Unit Tests	✅ 9 Passed
🌀 Generated Regression Tests	✅ 2 Passed
⏪ Replay Tests	🔘 None Found
🔎 Concolic Coverage Tests	🔘 None Found
📊 Tests Coverage	100.0%

⚙️ Existing Unit Tests and Runtime

Test File::Test Function	Original ⏱️	Optimized ⏱️	Speedup
integration/cache/test_factory.py::test_get_cache_types	976ns	834ns	17.0%✅
integration/cache/test_factory.py::test_register_and_create_custom_cache	813ns	539ns	50.8%✅
integration/cache/test_factory.py::test_register_class_directly_works	851ns	652ns	30.5%✅

🌀 Generated Regression Tests and Runtime

from __future__ import annotations

from collections.abc import Callable
from typing import Callable, ClassVar

# imports
import pytest  # used for our unit tests
from graphrag.cache.factory import CacheFactory

# function to test
# Copyright (c) 2024 Microsoft Corporation.
# Licensed under the MIT License


# Dummy PipelineCache for registration (minimal stub)
class PipelineCache:
    pass
from graphrag.cache.factory import CacheFactory

# --- Basic Test Cases ---

def test_get_cache_types_empty_registry():
    """Test get_cache_types returns empty list when no cache types are registered."""
    codeflash_output = CacheFactory.get_cache_types() # 831ns -> 656ns (26.7% faster)

















#------------------------------------------------
from __future__ import annotations

from collections.abc import Callable
from typing import Callable, ClassVar

# imports
import pytest  # used for our unit tests
from graphrag.cache.factory import CacheFactory

# function to test
# Copyright (c) 2024 Microsoft Corporation.
# Licensed under the MIT License


# Dummy PipelineCache class for testing purposes
class PipelineCache:
    pass
from graphrag.cache.factory import CacheFactory

# ------------------- BASIC TEST CASES -------------------

def test_get_cache_types_empty_registry():
    """Test get_cache_types returns empty list when nothing is registered."""
    codeflash_output = CacheFactory.get_cache_types() # 1.01μs -> 860ns (17.9% faster)

To edit these changes git checkout codeflash/optimize-CacheFactory.get_cache_types-mglq41ve and push.