Skip to content

⚡️ Speed up function encode_query by 24% #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function encode_query by 24% #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions src/deepgram/core/query_encoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,25 +24,25 @@ def traverse_query_dict(dict_flat: Dict[str, Any], key_prefix: Optional[str] = N


def single_query_encoder(query_key: str, query_value: Any) -> List[Tuple[str, Any]]:
if isinstance(query_value, pydantic.BaseModel) or isinstance(query_value, dict):
if isinstance(query_value, pydantic.BaseModel):
obj_dict = query_value.dict(by_alias=True)
else:
obj_dict = query_value
# Cache class and function lookups for tighter loops
_is_pydantic = isinstance
BaseModel = pydantic.BaseModel

if _is_pydantic(query_value, BaseModel):
obj_dict = query_value.dict(by_alias=True)
return traverse_query_dict(obj_dict, query_key)
elif isinstance(query_value, dict):
return traverse_query_dict(query_value, query_key)
elif isinstance(query_value, list):
encoded_values: List[Tuple[str, Any]] = []
for value in query_value:
if isinstance(value, pydantic.BaseModel) or isinstance(value, dict):
if isinstance(value, pydantic.BaseModel):
obj_dict = value.dict(by_alias=True)
elif isinstance(value, dict):
obj_dict = value

encoded_values.extend(single_query_encoder(query_key, obj_dict))
if _is_pydantic(value, BaseModel):
obj_dict = value.dict(by_alias=True)
encoded_values.extend(traverse_query_dict(obj_dict, query_key))
elif isinstance(value, dict):
encoded_values.extend(traverse_query_dict(value, query_key))
else:
encoded_values.append((query_key, value))

return encoded_values

return [(query_key, query_value)]
Expand All @@ -53,6 +53,7 @@ def encode_query(query: Optional[Dict[str, Any]]) -> Optional[List[Tuple[str, An
return None

encoded_query = []
extend = encoded_query.extend # Cache local attribute for speed
for k, v in query.items():
encoded_query.extend(single_query_encoder(k, v))
extend(single_query_encoder(k, v))
return encoded_query