fix: prefer codeflash.toml over pyproject.toml for config loading#1879
fix: prefer codeflash.toml over pyproject.toml for config loading#1879aseembits93 wants to merge 3 commits intomainfrom
Conversation
parse_config_file() computed closest_toml_path but never used it for actual config loading — it always fell through to find_pyproject_toml() which hard-prioritizes pyproject.toml. This caused codeflash.toml settings (e.g. Java module-root) to be ignored when pyproject.toml exists in the same or parent directory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Claude finished @aseembits93's task in 3m 41s —— View job PR Review SummaryPrek Checks✅ Ruff (lint + format) — all passed. No auto-fixable issues. Code ReviewPR classification: SMALL (17 lines of production code in
|
Summary
parse_config_file()computedclosest_toml_path(correctly preferringcodeflash.tomlat same depth) but never used it for config loading — always fell through tofind_pyproject_toml()which hard-prioritizespyproject.tomlcodeflash.tomlsettings (e.g. Javamodule-root) to be silently ignored when apyproject.tomlexists in the same or parent directoryclosest_toml_pathfor loading, with explicit tie-breaking:codeflash.tomlwins at same depthTest plan
--config-filebypasscodeflashno longer reports "Functions outside module-root" for Java functions when both config files exist🤖 Generated with Claude Code