Skip to content

⚡️ Speed up method ImportResolver._is_external_package by 42% in PR #1266 (alias_support_in_ts) #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method ImportResolver._is_external_package by 42% in PR #1266 (alias_support_in_ts) #1291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions codeflash/languages/javascript/import_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,20 +301,11 @@ def _is_external_package(self, module_path: str) -> bool:

"""
# Relative imports are not external
if module_path.startswith("."):
return False

# Absolute imports (starting with /) are project-internal
if module_path.startswith("/"):
return False

# @/ is a common path alias in Next.js/TypeScript projects mapping to project root
# These are internal imports, not external npm packages
if module_path.startswith("@/"):
return False

# ~/ is another common path alias pattern
if module_path.startswith("~/"):
if module_path.startswith((".", "/", "@/", "~/")):
return False

# Bare imports without ./ or ../ are external packages
Expand Down
Loading