fix: add missing pom.xml to Java Maven test fixture #1270
Closed
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The java_maven test fixture directory was missing a pom.xml file, causing BuildTool detection to fail and return UNKNOWN instead of MAVEN. This broke the test_detect_fixture_project test. Added a standard Maven POM with: - JUnit 5 dependencies (junit-jupiter-api, junit-jupiter-engine) - Maven Surefire plugin for test execution - Java 11 compiler configuration - UTF-8 encoding This enables proper Maven project detection and allows all Java configuration tests to pass.
misrasaurabh1
approved these changes
Feb 3, 2026
Resolved conflicts in pom.xml by accepting the omni-java version which has: - Updated artifactId: codeflash-test-fixture - Newer JUnit version: 5.10.0 - Simplified dependencies: junit-jupiter + junit-jupiter-params - Newer maven-surefire-plugin: 3.1.2 This brings the branch up to date with the latest changes from omni-java including the Comparator schema fix from PR #1272.
Contributor
Author
Closing PR - Changes Already MergedThis PR is no longer needed because the changes have already been incorporated into What Happened:
Verification:$ git diff origin/omni-java..HEAD
# No output - zero differencesConclusion:✅ The bug is fixed - pom.xml exists in omni-java Closing as the work is already complete through other merged PRs. Thank you for the review and approval! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Java Maven test fixture in
tests/test_languages/fixtures/java_maven/was missing apom.xmlfile, causing Maven build tool detection to fail.Problem
The
test_detect_fixture_projecttest was failing because:pom.xmlto identify Maven projectspom.xml, so detection returnedBuildTool.UNKNOWNinstead ofBuildTool.MAVENBuildTool.MAVENbut gotBuildTool.UNKNOWNSolution
Added a standard Maven
pom.xmlwith:Impact
test_detect_fixture_projecttest