feat: include package in Java function qualified names #1269
+91
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java function qualified names now include the package prefix for proper identification in markdown output and PR descriptions. Before: "Calculator.fibonacci" After: "com.example.Calculator.fibonacci" This ensures consistent fully-qualified naming for Java functions similar to how Python functions include their module path. The parents tuple now includes: 1. Package (type="package") - e.g., "com.example" 2. Class (type="ClassDef") - e.g., "Calculator" Functions without a package declaration maintain the previous behavior (just class.method). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When codeflash generates PR descriptions or explanations, Java functions appeared as:
Calculator.fibonacciinstead ofcom.example.Calculator.fibonacciThis made function references ambiguous, especially in large projects with multiple classes having the same name in different packages.
Solution
Include the package in the
parentstuple when discovering Java functions:The
qualified_nameproperty automatically builds the full path from parents.Before
After
Test plan
TestQualifiedNameWithPackagetest class with 4 test cases:test_qualified_name_includes_package- basic package inclusiontest_qualified_name_with_nested_package- deeply nested packagestest_qualified_name_without_package- default package behavior preservedtest_parents_include_package_and_class- verify parent structure🤖 Generated with Claude Code