fix: Java security and validation improvements #1267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses critical security vulnerabilities and improves error handling in the CodeFlash Java implementation.
Security Fixes
Error Handling Improvements
Changes
test_runner.py:
_validate_java_class_name()to validate Java identifier syntax_validate_test_filter()to sanitize test filter stringsget_test_run_command()before passing to Mavenbuild_tools.py:
_safe_parse_xml()for secure XML parsingET.parse()calls with secure versionTest Coverage
Added comprehensive test suite (
test_security.py) with 16 tests covering:All tests pass ✅
Impact
Test plan