-
Notifications
You must be signed in to change notification settings - Fork 21
alias support and vitest imports #1266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚡️Codeflash found 23% (0.23x) speedup for
ensure_vitest_importsincodeflash/languages/javascript/module_system.py⏱️ Runtime :
828 microseconds→673 microseconds(best of250runs)📝 Explanation and details
The optimized code achieves a 23% runtime improvement by eliminating redundant scanning of the code string and consolidating loop iterations over the code lines.
Key optimizations:
Single-pass global detection: The original code scanned for test globals twice—once with
any()to check if imports are needed, then again with a list comprehension to collect used globals. The optimized version computesused_globalsin a single pass and derivesneeds_importfrom whether that list is empty usingbool(used_globals). This eliminates one complete scan through the code string for all 9 test globals.Merged loop for insertion logic: The original code had two separate loops over
lines:insert_index(where to insert if no imports exist)last_import_index(the last existing import line)The optimized version merges these into a single loop, checking for both conditions simultaneously. This cuts the number of line iterations in half, reducing overhead from
enumerate(),strip()calls, and string comparisons.Performance characteristics:
The test results show the optimization is most effective for:
test,expect,it,afterAll, etc. benefit significantly from the single-pass detectionThe optimization maintains identical behavior—all test cases pass with the same output while running faster across all scenarios, from simple cases (~6-35% faster) to complex nested structures (~41% faster).
✅ Correctness verification report:
🌀 Click to see Generated Regression Tests
To test or edit this optimization locally
git merge codeflash/optimize-pr1266-2026-02-03T06.54.35Click to see suggested changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too large diff