Skip to content

[JS] Skip module conversion only for TypeScript projects with ts-jest #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Saga4 merged 5 commits into from
Feb 3, 2026
Merged

[JS] Skip module conversion only for TypeScript projects with ts-jest #1261

Saga4 merged 5 commits into from
Feb 3, 2026

Conversation

@mohammedahmed18
Copy link
Contributor

@mohammedahmed18 mohammedahmed18 commented Feb 2, 2026

Summary

  • Skip module system conversion (CommonJS ↔ ESM) only when ts-jest is installed AND the current language is TypeScript
  • ts-jest handles module interoperability natively, so conversion is unnecessary and can break valid imports
  • For non-TypeScript projects or projects without ts-jest, conversion still happens as before

Test plan

  • Added TestTsJestSkipsConversion test class for ts-jest scenarios
  • Added TestModuleSystemConversion test class for non-ts-jest scenarios
  • All 66 tests pass

🤖 Generated with Claude Code

@mohammedahmed18 @claude
fix: skip module conversion only for TypeScript projects with ts-jest
348a6ec 
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@Saga4 Saga4 merged commit e957843 into main Feb 3, 2026
7 of 27 checks passed
@Saga4 Saga4 deleted the fix/js-skip-module-conversion-for-ts-jest branch February 3, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Saga4 Saga4 Saga4 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mohammedahmed18 @Saga4