refactor: use FunctionToOptimize dataclass instead of raw strings in JS optimizatio #1256
+266
−234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JS optimization Replace raw function_name/qualified_name/class_name string parameters with the FunctionToOptimize dataclass throughout JavaScript optimization code. This provides better type safety and eliminates redundant parameters. Changes: - Add class_name property to FunctionToOptimize (similar to FunctionInfo) - Add from_function_info classmethod for FunctionInfo conversion - Update instrument.py transformers and functions to accept FunctionToOptimize - Update find_references.py to accept FunctionToOptimize - Update support.py and verifier.py callers - Update all test files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors JavaScript optimization code to use the FunctionToOptimize dataclass instead of passing function names as raw strings. This eliminates redundant parameters like class_name and provides better type safety throughout the codebase.
Test plan