Skip to content

⚡️ Speed up function function_has_return_statement by 77% in PR #1227 (limit-install-version) #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codeflash-ai wants to merge 1 commit into from
Closed

⚡️ Speed up function function_has_return_statement by 77% in PR #1227 (limit-install-version) #1235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion codeflash/discovery/functions_to_optimize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,7 +1001,19 @@ def filter_files_optimized(file_path: Path, tests_root: Path, ignore_paths: list

def function_has_return_statement(function_node: FunctionDef | AsyncFunctionDef) -> bool:
# Custom DFS, return True as soon as a Return node is found
stack: list[ast.AST] = [function_node]
# Handle edge case where a Return node is passed directly
if isinstance(function_node, ast.Return):
return True

body = function_node.body
if not body:
return False
# Fast-path: check top-level body statements first (common case)
for node in body:
if isinstance(node, ast.Return):
return True
# Continue DFS from the body nodes (skip the wrapper function node)
stack: list[ast.AST] = list(body)
while stack:
node = stack.pop()
if isinstance(node, ast.Return):
Expand Down
Loading