Open
Conversation
### Commit Checklist - [ ] Remove UNUSED comment code - [ ] Remove any logging like console.log - [ ] Remove all warnings and errors while build - [ ] Check vulnerabilities - [ ] Make sure build for production is working. Try running command for prod build in local. - [ ] Fix prettier: `npx prettier --write .` - [ ] Fix eslint: `npx eslint src\ --fix ` command - [ ] Push package.lock only if you used npm, push yarn.lock only if you used yarn. NPM will udpate both lock file so make sure you dont push yarn.lock updated by NPM - [ ] WCAG ### General - [ ] Follow import structure. module/third-party/files/component/style/types/asset - [ ] Try to use theme for design like palette, typography, variant, components, etc. (don't use custom color code anyhow) - [ ] Before adding custom style follow our pre-built components/elements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Checklist
npx prettier --write .npx eslint src\ --fixcommandGeneral