fixed: types: PupeteerConfig.waitForNavigation can be an array#5222
fixed: types: PupeteerConfig.waitForNavigation can be an array#5222kobenguyent merged 4 commits intocodeceptjs:3.xfrom
Conversation
|
looks like the doc link is deprecated. New one https://github.com/puppeteer/puppeteer/blob/main/docs/api/puppeteer.waitforoptions.md |
|
Thanks for the catch. I have tried to fix all other outdated There is only the one "Repository" link in docs/helpers/puppeteer-firefox.md that I could not resolve in the new repository. Beside that, I found a broken link for Playwright's "waitForNavigation" that I have also fixed. Can you tell me something about the completely rewritten formatting in the markdown files? Should I care about that? |
@danielrentz per my best knowledge, those changes of markdown files are something we shall not worry about. |
Motivation/Description of the PR
The documentation of
PupeteerConfig.waitForNavigationalready says it: "Array values are accepted as well."The commit hook seems to rewrite the entire formatting of
puppeteer.md. Afternpm run docsand before committing, I have had a single changed line there.Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)