fix(utils): resolve command injection vulnerability in emptyFolder (3.x)#5190
Merged
kobenguyent merged 2 commits intocodeceptjs:3.xfrom Sep 21, 2025
Merged
fix(utils): resolve command injection vulnerability in emptyFolder (3.x)#5190kobenguyent merged 2 commits intocodeceptjs:3.xfrom
emptyFolder (3.x)#5190kobenguyent merged 2 commits intocodeceptjs:3.xfrom
Conversation
f27ad44 to
c96ca5b
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical command injection vulnerability in the emptyFolder utility function by replacing the unsafe shell command execution with safe Node.js filesystem operations.
- Replaces
child_process.execSyncwith shell command concatenation with nativefsoperations - Adds safety check for non-existent directories
- Changes from async to synchronous function signature
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
@kobenguyent Could you re-trigger a build and merge it if ok? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
This PR resolves a command injection vulnerability in the
emptyFolderutility (on the3.xbranch); see GHSA-34w8-mcwr-vg29.Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)