[WIP] CodeceptJS 3.7.x: "tryTo" and "session" do not work together#5120
Merged
kobenguyent merged 2 commits into3.xfrom Sep 1, 2025
Merged
[WIP] CodeceptJS 3.7.x: "tryTo" and "session" do not work together#5120kobenguyent merged 2 commits into3.xfrom
kobenguyent merged 2 commits into3.xfrom
Conversation
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
Copilot stopped work on behalf of
kobenguyent due to an error
September 1, 2025 04:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tryToandsessionuserecorder.session.start()but the session management doesn't support nestingsessionIdis a single variable that gets overwritten when nested sessions startKey Changes:
sessionStackarray to track nested sessions inlib/recorder.jsrecorder.session.start()to push current session to stack instead of restoring it immediatelyrecorder.session.restore()to pop parent session from stack when availablereset()method to clear the session stackThe fix enables proper nesting of effects that use recorder sessions, resolving the hanging issue when
tryTois used insidesession().Fixes #5116.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.