fix: add missing endpoints to the default list of probed endpoints#5361
Conversation
8380fbc to
7557f8f
Compare
|
This is false positive. The listed endpoint IDs are just valid and used for Spring Boot 1.x applications. The comment states it correctly:
The fallback mechanism uses Mono.switchIfEmpty() in ChainingStrategy.java:25, so for a Spring Boot >= 2 app:
That's why I am reluctant to merge this PR as it will try to probed for endpoints that do not exist in Spring Boot 1. |
|
If I remember correctly, the strategy may be configured or somehow mangled to use the probe-based one (e.g.: for security reasons) which then would miss some endpoints.
The property is mutable, so if you really want enforce them it should then be read-only.
Of course, up to you. |
Good catch! Thanks for pointing this out. Yes, when |
|
You're welcome. |
This PR adds some missed endpoint IDs to the default list of probed endpoints configured in de.codecentric.boot.admin.server.config.AdminServerProperties#probedEndpoints