Fully qualify references to generated interfaces#89
Open
simonmckenzie wants to merge 7 commits intocodecentric:masterfrom
Open
Fully qualify references to generated interfaces#89simonmckenzie wants to merge 7 commits intocodecentric:masterfrom
simonmckenzie wants to merge 7 commits intocodecentric:masterfrom
Conversation
simonmckenzie
commented
Sep 3, 2025
AutomaticInterface/AutomaticInterface/AutomaticInterfaceGenerator.cs
Outdated
Show resolved
Hide resolved
011fcc7 to
332a2db
Compare
simonmckenzie
commented
Sep 3, 2025
simonmckenzie
commented
Sep 3, 2025
simonmckenzie
commented
Sep 3, 2025
simonmckenzie
commented
Sep 3, 2025
f449545 to
dfcb5b7
Compare
dfcb5b7 to
28df788
Compare
Contributor
Author
|
This is ready for review again - I just had a last minute refactoring idea :) |
Collaborator
|
Could you be so kind and merge master into this? Than I will merge it as 6.x I think because it's potentially breaking |
Contributor
Author
|
Not a problem @ChristianSauer. I hope to get this done next week. |
28df788 to
12ad491
Compare
Contributor
Author
|
Hi @ChristianSauer, I've rebased the branch on master, but happy to get the other PR merged first, then I can rebase and refactor again, as I think I should probably move the other PR's changes into the |
12ad491 to
7302977
Compare
simonmckenzie
commented
Nov 12, 2025
5d8726b to
4cce479
Compare
Collaborator
|
@simonmckenzie I merged the other PR first :) |
This addresses an issue where, when a class references a generated interface, those references are not fully qualified, resulting in an interface that doesn't compile. The change is to precalculate the list of interface names that will be generated, and, during symbol string generation, replace unrecognised symbols with generated names _where a single unambiguous match can be made between the symbol and the list of interfaces being generated_.
- Change approach to use `ToDisplayParts`, which removes the need for regex parsing of generated code - Fix bug in `ReplaceWithInferredInterfaceName` where dots weren't being escaped - Add tests to ensure partially qualified references will be resolved correctly
…class; refactor This centralises the rendering logic plus simplifies the implementation to use `ITypeSymbol.WithNullableAnnotation` and hands the rendering off to the default `ToDisplayString` implementation
4cce479 to
9148e56
Compare
Contributor
Author
|
Hi @ChristianSauer, I've rebased again and refactored the changes from #85 into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses an issue where, when a class references a generated interface, those references are not fully qualified, resulting in an interface that doesn't compile. See #87.
The change is to precalculate the list of interface names that will be generated, and, during symbol string generation, replace unrecognised symbols with generated names where a single unambiguous match can be made between the symbol and the list of interfaces being generated.
For the example provided in #87, the code will now generate this output: