fix: use composite key for CardInfo in HelpScreen grid#244
Merged
codebutler merged 1 commit intomasterfrom Feb 22, 2026
Merged
Conversation
Multiple CardInfo entries can share the same nameRes (e.g., Troika has both MifareClassic and MifareUltralight variants). Using nameRes.key alone as the LazyVerticalGrid item key caused a duplicate key crash when scrolling. Add CardInfo.uniqueKey that combines nameRes.key with cardType.name, and use it for grid keys and card selection in HelpScreen. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CardInfoentries can share the samenameRes(e.g., Troika registers both MifareClassic and MifareUltralight variants withRes.string.card_name_troika)LazyVerticalGridusednameRes.keyalone as the item key, causing a duplicate key crash when scrollingCardInfo.uniqueKeycomputed property ("${nameRes.key}:${cardType.name}") and use it for grid keys and card selectionTest plan
🤖 Generated with Claude Code