Skip to content

Update the default method when rendering a 404 #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonodrew wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −6
Open

Update the default method when rendering a 404 #2519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions app/controllers/application_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,7 @@ class ApplicationController < ActionController::Base
before_action :accept_terms, if: :logged_in?

def render_not_found
respond_to do |format|
format.html { render template: 'errors/not_found', layout: false, status: :not_found }
format.all { head :not_found }
end
render template: 'errors/not_found', layout: false, status: :not_found
end

protected
Expand Down
3 changes: 1 addition & 2 deletions app/controllers/invitations_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ def cancel_meeting
private

def set_invitation
@invitation = Invitation.find_by(token: params[:token])
raise ActionController::RoutingError, 'Invitation not found' unless @invitation
@invitation = Invitation.find_by!(token: params[:token])
end

def load_invitation
Expand Down
Loading