Skip to content

fix: return 404 when invitation not found by token#2517

Merged
jonodrew merged 2 commits intocodebar:masterfrom
mroderick:fix-error-656-undefined-method-event-for-nil
Mar 10, 2026
Merged

fix: return 404 when invitation not found by token#2517
jonodrew merged 2 commits intocodebar:masterfrom
mroderick:fix-error-656-undefined-method-event-for-nil

Conversation

@mroderick
Copy link
Collaborator

@mroderick mroderick commented Mar 10, 2026

Summary

  • Fixes NoMethodError "undefined method 'event' for nil" in InvitationsController#show
  • Returns 404 instead of 500 when invitation token is invalid
  • Adds tests for 404 behavior on show, attend, and reject actions

Rollbar

https://app.rollbar.com/a/codebar-production/fix/item/codebar-production/656#detail

@mroderick mroderick requested a review from jonodrew March 10, 2026 18:27
@mroderick mroderick marked this pull request as ready for review March 10, 2026 18:27
@mroderick mroderick force-pushed the fix-error-656-undefined-method-event-for-nil branch from 95227d1 to 6c83d92 Compare March 10, 2026 18:36
Copy link
Contributor

@KimberleyCook KimberleyCook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jonodrew jonodrew merged commit 972c892 into codebar:master Mar 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants